Hello Ravi Nori, I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/19543 to review the following change. Change subject: webadmin: Attempt to add a 3.2 host into 3.3 env fails but the host cannot be removed ...................................................................... webadmin: Attempt to add a 3.2 host into 3.3 env fails but the host cannot be removed When a 3.2 host is added to 3.3 env the server returns NonOperationalReason___CLUSTER_VERSION_INCOMPATIBLE_WITH_CLUSTER message. Since this message is not available in the frontend there is an exception thrown when a user clicks on the row for the host. So the row is not selected resulting in the action buttons not being activated. This patch adds a new message to LocalizedEnums Change-Id: Ib9763a444cb4c96d407e7e8bee55b72bccaff89f Bug-Url: https://bugzilla.redhat.com/1004675 Signed-off-by: Ravi Nori <rn...@redhat.com> Signed-off-by: Tal Nisan <tni...@redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/19543/1 diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java index 301bb4a..4f310e9 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java @@ -30,6 +30,8 @@ String NonOperationalReason___GLUSTER_HOST_UUID_NOT_FOUND(); + String NonOperationalReason___CLUSTER_VERSION_INCOMPATIBLE_WITH_CLUSTER(); + String NonOperationalReason___EMULATED_MACHINES_INCOMPATIBLE_WITH_CLUSTER(); String UsbPolicy___ENABLED_LEGACY(); diff --git a/frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties b/frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties index 681fbb2..4976a79 100644 --- a/frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties +++ b/frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties @@ -5,6 +5,7 @@ NonOperationalReason___NETWORK_UNREACHABLE=One of the Logical Networks defined for this Cluster is Unreachable by the Host. NonOperationalReason___VM_NETWORK_IS_BRIDGELESS=One of the host's networks is configured as a non-VM network while its Logical Network definition specifies it is a VM network. Sync network. NonOperationalReason___VERSION_INCOMPATIBLE_WITH_CLUSTER=Host's Compatibility Version doesn't match the Cluster's Compatibility Version. +NonOperationalReason___CLUSTER_VERSION_INCOMPATIBLE_WITH_CLUSTER=Host's Cluster Compatibility Version doesn't match the Cluster's Compatibility Version. NonOperationalReason___KVM_NOT_RUNNING=KVM is not running on the Host. NonOperationalReason___TIMEOUT_RECOVERING_FROM_CRASH=Timeout connecting to Host. NonOperationalReason___GLUSTER_COMMAND_FAILED=Gluster command failed on server. -- To view, visit http://gerrit.ovirt.org/19543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9763a444cb4c96d407e7e8bee55b72bccaff89f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches