Alon Bar-Lev has posted comments on this change.
Change subject: ovirt-live: prepare ovirt-live for ovirt 3.3
......................................................................
Patch Set 3:
(4 comments)
also remove last empty lines from all files... :)
....................................................
File
centos/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py
Line 178: oliveconst.Stages.COPY_ISO,
Line 179: ),
Line 180: )
Line 181: def _createvm(self):
Line 182: # Defins OS param for the boot option
no need for ovbios comment...
Line 183: params = self._ovirtsdk_xml.params
Line 184: MB = 1024*1024
Line 185: GB = 1024*MB
Line 186:
Line 183: params = self._ovirtsdk_xml.params
Line 184: MB = 1024*1024
Line 185: GB = 1024*MB
Line 186:
Line 187: # Create VM
no need for ovbios comment...
Line 188: vm = self._engine_api.vms.add(
Line 189: params.VM(
Line 190: name='local_vm',
Line 191: memory=1*GB,
Line 200: template=self._engine_api.templates.get('Blank'),
Line 201: ),
Line 202: )
Line 203:
Line 204: # Create NIC
no need for ovbios comment...
Line 205: vm.nics.add(
Line 206: params.NIC(
Line 207: name='eth0',
Line 208: network=params.Network(name='ovirtmgmt'),
Line 223: format='cow',
Line 224: bootable=True,
Line 225: ),
Line 226: )
Line 227:
two spaces :)
--
To view, visit http://gerrit.ovirt.org/19200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3930256ebddb4eed912d216922861f7593d93dea
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
