Noam Slomianko has uploaded a new change for review. Change subject: webadmin: Disable + sign in custom properties ......................................................................
webadmin: Disable + sign in custom properties When there are no more possible values disable the + sign in custom properties Change-Id: I40e391566dd3bcced2a345ce6a56e2244ac94294 Bug-Url: https://bugzilla.redhat.com/1001159 Signed-off-by: Noam Slomianko <nslom...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java 3 files changed, 23 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/19452/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java index ee3a0f8..d337353 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java @@ -84,7 +84,6 @@ object.getAddLine().execute(); } }); - minusButton.addClickHandler(new ClickHandler() { @Override public void onClick(ClickEvent event) { @@ -137,4 +136,12 @@ this.enabled = enabled; } + public void setPlusButtonEnabled(boolean enabled) { + plusButton.setEnabled(enabled); + } + + public void setMinusButtonEnabled(boolean enabled) { + minusButton.setEnabled(enabled); + } + } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java index 7716b25..136fdb5 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java @@ -67,6 +67,13 @@ panel.add(keyValueLineWidget); keyValueLineWidget.edit(keyValueLineModel); keyValueLineWidget.setEnabled(enabled); + + if (list.size() == 1 && object.keysUsedCount() == 0) { + keyValueLineWidget.setMinusButtonEnabled(false); + } + if (list.size() == object.possibleKeysCount()) { + keyValueLineWidget.setPlusButtonEnabled(false); + } } } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java index dedda24..e3cf8c1 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java @@ -213,6 +213,14 @@ } } + public int keysUsedCount() { + return keyValueMap_used == null ? 0 : keyValueMap_used.size(); + } + + public int possibleKeysCount() { + return allKeyValueMap == null ? 0 : allKeyValueMap.size(); + } + @Override public void addLine(KeyValueLineModel lineModel) { List<KeyValueLineModel> list = -- To view, visit http://gerrit.ovirt.org/19452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I40e391566dd3bcced2a345ce6a56e2244ac94294 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslom...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
