Martin Sivák has posted comments on this change. Change subject: policy: Fix balloon policy syntax and semantics ......................................................................
Patch Set 1: (1 comment) .................................................... File doc/balloon.rules Line 46: # Given current conditions, determine the ideal guest memory size Line 47: (defvar guest_used_mem (- (guest.StatAvg "balloon_cur") Line 48: (guest.StatAvg "mem_unused"))) Line 49: (defvar balloon_min (max guest.balloon_min (+ guest_used_mem Line 50: (* guest_free_percent guest.balloon_cur)))) Shouldn't we use min_guest_free_percent here as well? Line 51: # But do not change it too fast Line 52: (defvar balloon_size (* guest.balloon_cur Line 53: (- 1 max_balloon_change_percent))) Line 54: (if (< balloon_size balloon_min) -- To view, visit http://gerrit.ovirt.org/19416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fba77bb5c42b29ab479752e335cbc11ed0a298b Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Better Saggi <bettersa...@gmail.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
