Kanagaraj M has posted comments on this change.
Change subject: webadmin : volume rebalance status bug corrected
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeRebalanceStatusModel.java
Line 124: refreshDetails(volumeEntity);
Line 125: }
Line 126:
Line 127: };
Line 128: refresh.schedule(10000);
The problem still exists
You are just cancelling the last timer not the previous one
If you see above, after each request has returned you are creating a new timer
and scheduling.
Can this timer be re-used? May be you can create the time in the constructor
and the schedule can be triggered from wherever you want
Line 129: }
Line 130:
Line 131: public void cancelRefresh() {
Line 132: if(refresh == null) {
--
To view, visit http://gerrit.ovirt.org/19448
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc9f37cc55ee540250b434da3ad06de90a502591
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
