Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Add 'get_all_values' to configfile.py ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/pythonlib/ovirt_engine/configfile.py Line 143: return default Line 144: else: Line 145: return int(value) Line 146: Line 147: def get_all_values(self): I tried to be as similar to configparser... but I do not like its items() function, as it does not return a map. so in this case, I suggest to use property and not function, I suggest 'values' name. Line 148: return self._values Line 149: Line 150: -- To view, visit http://gerrit.ovirt.org/19445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27fcd1335a2a264d2f1f6000815c7ddec578fbe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
