Michael Pasternak has posted comments on this change. Change subject: rest: VirtIO-SCSI enabled flag ......................................................................
Patch Set 3: Code-Review-1 (1 comment) please add: -BackendVmsResourceTest -BackendVmResourceTest tests thanks. .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 2436: <xs:element name="guest_info" type="GuestInfo" minOccurs="0" maxOccurs="1"/> Line 2437: <xs:element ref="quota" minOccurs="0" maxOccurs="1"/> Line 2438: <xs:element ref="usb" minOccurs="0" maxOccurs="1"/> Line 2439: <xs:element name="tunnel_migration" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 2440: <xs:element name="virtio_scsi_enabled" type="xs:boolean" minOccurs="0" maxOccurs="1"/> i think it makes sense implementing it this way: <virtio_scsi> <enabled>true|false</enabled> </virtio_scsi> because: 1. it gives flexibility for passing additional parameters in virtio_scsi context 2. in sake of consistency with other elements, such as Console, PowerManagement, KSM, TransparentHugePages, HighAvailability, Usb, etc Line 2441: <xs:element ref="permissions" minOccurs="0" maxOccurs="1"/> Line 2442: <xs:element ref="vmpool" minOccurs="0" maxOccurs="1"> Line 2443: <xs:annotation> Line 2444: <xs:appinfo> -- To view, visit http://gerrit.ovirt.org/19154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I481025152b20579ac615d9023ed0cef9b64558e1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
