Lior Vernia has uploaded a new change for review.
Change subject: webadmin: Removed dead code
......................................................................
webadmin: Removed dead code
Was there originally to enable removing a VNIC if hotplug was
available, but then the removal was disabled to make users explicitly
unplug VNIC first. The code stayed there, some of it was removed due
to findbugs findings but some was left.
Change-Id: I20391d81e8bdb439191f1b47e0b8825fbf6f5e4e
Signed-off-by: Lior Vernia <lver...@redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java
1 file changed, 0 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/19436/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java
index 39549a5..3f4b629 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java
@@ -12,7 +12,6 @@
import org.ovirt.engine.core.common.queries.IdQueryParameters;
import org.ovirt.engine.core.common.queries.VdcQueryType;
import org.ovirt.engine.core.compat.StringHelper;
-import org.ovirt.engine.core.compat.Version;
import org.ovirt.engine.ui.frontend.AsyncQuery;
import org.ovirt.engine.ui.frontend.INewAsyncCallback;
import org.ovirt.engine.ui.uicommonweb.Linq;
@@ -22,7 +21,6 @@
import org.ovirt.engine.ui.uicompat.ConstantsManager;
import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs;
-@SuppressWarnings("unused")
public class VmInterfaceListModel extends SearchableListModel
{
@@ -283,26 +281,9 @@
updateActionAvailability();
}
- protected void updateConfigValues()
- {
- if (getEntity() == null)
- {
- return;
- }
- VM vm = getEntity();
- Version clusterCompatibilityVersion =
vm.getVdsGroupCompatibilityVersion() != null
- ? vm.getVdsGroupCompatibilityVersion() : new Version();
- }
-
@Override
public VM getEntity() {
return (VM) super.getEntity();
- }
-
- @Override
- public void setEntity(Object value) {
- super.setEntity(value);
- updateConfigValues();
}
@Override
--
To view, visit http://gerrit.ovirt.org/19436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20391d81e8bdb439191f1b47e0b8825fbf6f5e4e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
