Omer Frenkel has posted comments on this change. Change subject: engine-core: Cleanup POSIXStorageHelper ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java Line 52: connections)).getReturnValue(); you can use runVdsCommand instead of Backend.getInstance().getInstance().getResourceManager().getResourceManager().RunVdsCommand .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/POSIXStorageHelper.java Line 17: private static final Log log = LogFactory.getLog(POSIXStorageHelper.class); you have an extra space char after the final keyword -- To view, visit http://gerrit.ovirt.org/3509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3a8432271bf7166d56555fa72e5a488af340d14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
