Maor Lipchuk has posted comments on this change.
Change subject: core: InitVdsOnUp - proceed regardless of problematic
iso/export domain
......................................................................
Patch Set 2:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 269: runVdsCommand(VDSCommandType.GetStats, new
VdsIdAndVdsVDSCommandParametersBase(getVds()));
Line 270: List<Guid> problematicDomainsIds =
IrsBrokerCommand.fetchDomainsReportedAsProblematic(getVds().getStoragePoolId(),
getVds().getDomains());
Line 271: for (Guid domainId : problematicDomainsIds) {
Line 272: StorageDomainStatic domainInfo =
getStorageDomainStaticDAO().get(domainId);
Line 273: log.errorFormat("Storage Domain {0} of pool {1} is in
problem in host {1}",
Consider to rephrase "Storage domain {0} of pool" to "Storage domain {0}
attached to pool {1}....."
Line 274: domainInfo != null ?
domainInfo.getStorageName() : domainId,
Line 275: getStoragePool().getName(),
Line 276: getVds().getName());
Line 277: if (domainInfo == null ||
domainInfo.getStorageDomainType().isDataDomain()) {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1105: AuditLogDirector.log(logable,
Line 1106: AuditLogType.VDS_DOMAIN_DELAY_INTERVAL);
Line 1107: }
Line 1108:
Line 1109: public List<Guid>
checkIfDomainsReportedAsProblematic(List<VDSDomainsData> vdsDomainsData) {
Maybe a more appropriate name would be "getReportedProblematicDomains(...)"
The checkif prefix does not reflect that now, we return list instead of boolean
Line 1110: List<Guid> domainsInProblem = new LinkedList<>();
Line 1111: Set<Guid> domainsInPool = new HashSet<Guid>(
Line 1112:
DbFacade.getInstance().getStorageDomainStaticDao().getAllIds(
Line 1113: _storagePoolId,
StorageDomainStatus.Active));
Line 1118: if
(domainsInPool.contains(vdsDomainData.getDomainId())) {
Line 1119: if (isDomainReportedAsProblematic(vdsDomainData,
true)) {
Line 1120:
domainsInProblem.add(vdsDomainData.getDomainId());
Line 1121: }
Line 1122:
domainWhicWereSeen.add(vdsDomainData.getDomainId());
Not related to this patch, but consider to change it in another patch :
/s/domainWhicWereSeen/domainWhichWereSeen
Line 1123: }
Line 1124: }
Line 1125: domainsInPool.removeAll(domainWhicWereSeen);
Line 1126: if (domainsInPool.size() > 0) {
--
To view, visit http://gerrit.ovirt.org/17986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32372aa80d7193a814f2500231d4545d2b1a5fc3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
