Allon Mureinik has posted comments on this change.
Change subject: core: Merge VdcUser and DbUser
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Looks great to me, giving only +1 so that UI and REST maintainers have a chance
to review too.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDbUserByExternalIdQuery.java
Line 11: }
Line 12:
Line 13: @Override
Line 14: protected void executeQueryCommand() {
Line 15: DbUserDAO dao = DbFacade.getInstance().getDbUserDao();
use getDbFacade() instead of DbFacade.getInstance()
Line 16: DbUser user = dao.getByExternalId(
Line 17: getParameters().getDomain(),
Line 18: getParameters().getExternalId()
Line 19: );
--
To view, visit http://gerrit.ovirt.org/17224
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ed315043858260ba997203b8e3fc05feb0bad20
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
