Michael Pasternak has posted comments on this change. Change subject: restapi: Modified gluster volume rebalance action ......................................................................
Patch Set 8: Code-Review-1 (2 comments) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 3245: <xs:element name="stripe_count" type="xs:unsignedShort" minOccurs="0" maxOccurs="1"/> Line 3246: <xs:element ref="bricks" minOccurs="0" maxOccurs="1"/> Line 3247: <xs:element ref="options" minOccurs="0" maxOccurs="1"/> Line 3248: <xs:element ref="status" minOccurs="0" maxOccurs="1"/> Line 3249: <xs:element ref="task" minOccurs="0" maxOccurs="1"/> this is irrelevant to all resources extendingBaseResource Line 3250: </xs:sequence> Line 3251: </xs:extension> Line 3252: </xs:complexContent> Line 3253: </xs:complexType> Line 3678: <xs:element name="step_id" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 3679: </xs:sequence> Line 3680: </xs:extension> Line 3681: </xs:complexContent> Line 3682: </xs:complexType> sahina, how this patch complies with conversation we had last week? we agreed that you will use "existing Step API" ... Line 3683: -- To view, visit http://gerrit.ovirt.org/18208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9fd560cc1b6a0db9cc28647bc311cb9f1b9e3b3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
