Omer Frenkel has posted comments on this change.

Change subject: engine: Host activate -check gluster availability
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/GlusterMonitoringStrategy.java
Line 28:         VDSReturnValue returnValue = 
ResourceManager.getInstance().runVdsCommand(VDSCommandType.GlusterServersList,
Line 29:                 new VdsIdVDSCommandParametersBase(vds.getId()));
Line 30:         if (!returnValue.getSucceeded()) {
Line 31:             vds.setStatus(VDSStatus.NonOperational);
Line 32:             
vds.setNonOperationalReason(NonOperationalReason.GLUSTER_COMMAND_FAILED);
please also call the vdsNonOperational event (you can see how this is done in 
the virtMonitoringStrategy
Line 33:         }
Line 34:     }
Line 35: 
Line 36:     @Override


-- 
To view, visit http://gerrit.ovirt.org/16898
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If673e32ed6480187ddcf6f9ecf8f0007e203b98d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to