Alon Bar-Lev has posted comments on this change. Change subject: restapi: Deploy as independent .war ......................................................................
Patch Set 3: (3 comments) .................................................... File ovirt-engine.spec.in Line 49: %global engine_run %{_localstatedir}/run/%{engine_name} Line 50: %global engine_cache %{_localstatedir}/cache/%{engine_name} Line 51: %global engine_tmp %{_localstatedir}/tmp/%{engine_name} Line 52: Line 53: %global restapi_war %{engine_data}/restapi.war can we drop this and just put all wars at %{engine_data}/wars? this applies to the entire series. %global engine_wars %{engine_data}/wars Line 54: %global root_war %{engine_ear}/root.war Line 55: Line 56: # The name and ids of the engine user and group: Line 57: %global engine_user ovirt Line 111: MAVENPOM_DIR=%{_mavenpomdir} \\\ Line 112: PKG_SYSCONF_DIR=%{engine_etc} \\\ Line 113: PKG_DOC_DIR=%{engine_doc} \\\ Line 114: PKG_EAR_DIR=%{engine_ear} \\\ Line 115: PKG_RESTAPI_DIR=%{restapi_war} \\\ PKG_WARS_DIR=%{engine_wars} Line 116: PKG_PKI_DIR=%{engine_pki} \\\ Line 117: PKG_JBOSS_MODULES=%{engine_jboss_modules} \\\ Line 118: PKG_CACHE_DIR=%{engine_cache} \\\ Line 119: PKG_LOG_DIR=%{engine_log} \\\ .................................................... File packaging/conf/engine.conf.defaults.in Line 107: # application server started by the engine. This is a list of space Line 108: # separated files or directories that should exist under Line 109: # /usr/share/ovirt-engine: Line 110: # Line 111: ENGINE_APPS="engine.ear restapi.war" can we add ENGINE_APPS_PATH which will contain the search path of applications? default we can put @ENGINE_WARS@:@ENGINE_USR@ Line 112: Line 113: # Line 114: # Flags to enable or disable the web server (the proxy) and the Line 115: # connectors of the application server: -- To view, visit http://gerrit.ovirt.org/13718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11558b95f3c99cad2edc2d42170fce7eb88c005b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches