Sahina Bose has posted comments on this change.
Change subject: gluster: BLL Cmd: commit remove bricks async task
......................................................................
Patch Set 4:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommand.java
Line 40: }
Line 41:
Line 42: if (volume.getAsyncTask() == null ||
volume.getAsyncTask().getType() != GlusterTaskType.REMOVE_BRICK
Line 43: || volume.getAsyncTask().getStatus() !=
JobExecutionStatus.FINISHED) {
Line 44: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_REMOVE_BRICKS_NOT_FINISHED);
Please use failCanDoAction
Line 45: }
Line 46:
Line 47: return true;
Line 48: }
Line 65:
handleVdsError(AuditLogType.GLUSTER_VOLUME_REMOVE_BRICKS_COMMIT_FAILED,
returnValue.getVdsError().getMessage());
Line 66: return;
Line 67: }
Line 68:
Line 69: endStepJob();
While committing the bricks, the Step message should be different from the
remove. You may need to update the step message here.
Line 70: releaseVolumeLock();
Line 71:
getReturnValue().setActionReturnValue(returnValue.getReturnValue());
Line 72: }
Line 73:
--
To view, visit http://gerrit.ovirt.org/19100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf0e615b067638b56af81e2dabe06512d92d73a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
