Cheryn Tan has posted comments on this change.
Change subject: backend,frontend: add more specific glance errors
......................................................................
Patch Set 2:
(3 comments)
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 967: ACTION_TYPE_FAILED_SERVER_STATUS_NOT_UP=Cannot ${action} ${type}. The
server ${VdsName} is not UP.
Line 968: ACTION_TYPE_FAILED_SERVER_SERVICE_NOT_FOUND=Cannot ${action} ${type}.
Service not found.
Line 969: ACTION_TYPE_FAILED_SERVICE_ALREADY_RUNNING=Cannot ${action} ${type}.
Service ${service} is already running on server ${server}.
Line 970: ACTION_TYEPE_FAILED_SERVICE_ALREADY_STOPPED=Cannot ${action} ${type}.
Service ${service} already stopped on Server ${server}.
Line 971: ACTION_TYPE_FAILED_IMAGE_DOWNLOAD_ERROR=Cannot ${action} ${type}. An
unexpected error occurred trying to inspect the image content.
This isn't very descriptive -- if a user encounters this error, what should
they do to fix it?
I'd suggest changing it to "Cannot ${action} ${type}. The image content could
not be detected. Please re-import the image."
(kind of taking a wild guess about the solution here, sorry about that)
Line 972: ACTION_TYPE_FAILED_IMAGE_NOT_SUPPORTED=Cannot ${action} ${type}. The
image format is not supported.
Line 973: ACTION_TYPE_FAILED_IMAGE_UNRECOGNIZED=Cannot ${action} ${type}. The
image is missing or its format is corrupted or unrecognizable
Line 974: ACTION_TYPE_FAILED_VOLUME_OPERATION_IN_PROGRESS=Cannot ${action}
${type}. A task is in progress on the volume ${volumeName} in cluster
${vdsGroup}.
Line 975: ACTION_TYPE_FAILED_GLUSTER_VOLUME_REBALANCE_NOT_STARTED=Cannot
${action} ${type}. Rebalance is not running on the volume ${volumeName} in
cluster ${vdsGroup}.
Line 968: ACTION_TYPE_FAILED_SERVER_SERVICE_NOT_FOUND=Cannot ${action} ${type}.
Service not found.
Line 969: ACTION_TYPE_FAILED_SERVICE_ALREADY_RUNNING=Cannot ${action} ${type}.
Service ${service} is already running on server ${server}.
Line 970: ACTION_TYEPE_FAILED_SERVICE_ALREADY_STOPPED=Cannot ${action} ${type}.
Service ${service} already stopped on Server ${server}.
Line 971: ACTION_TYPE_FAILED_IMAGE_DOWNLOAD_ERROR=Cannot ${action} ${type}. An
unexpected error occurred trying to inspect the image content.
Line 972: ACTION_TYPE_FAILED_IMAGE_NOT_SUPPORTED=Cannot ${action} ${type}. The
image format is not supported.
Can we add something helpful here, for example what image formats are
supported? Something like "Cannot ${action} ${type}. Only QCOW2 image formats
are supported."
Line 973: ACTION_TYPE_FAILED_IMAGE_UNRECOGNIZED=Cannot ${action} ${type}. The
image is missing or its format is corrupted or unrecognizable
Line 974: ACTION_TYPE_FAILED_VOLUME_OPERATION_IN_PROGRESS=Cannot ${action}
${type}. A task is in progress on the volume ${volumeName} in cluster
${vdsGroup}.
Line 975: ACTION_TYPE_FAILED_GLUSTER_VOLUME_REBALANCE_NOT_STARTED=Cannot
${action} ${type}. Rebalance is not running on the volume ${volumeName} in
cluster ${vdsGroup}.
Line 976: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_VALUES=Cannot ${action}
${type}. All three values are needed in order to define QoS on each network
directions.
Line 969: ACTION_TYPE_FAILED_SERVICE_ALREADY_RUNNING=Cannot ${action} ${type}.
Service ${service} is already running on server ${server}.
Line 970: ACTION_TYEPE_FAILED_SERVICE_ALREADY_STOPPED=Cannot ${action} ${type}.
Service ${service} already stopped on Server ${server}.
Line 971: ACTION_TYPE_FAILED_IMAGE_DOWNLOAD_ERROR=Cannot ${action} ${type}. An
unexpected error occurred trying to inspect the image content.
Line 972: ACTION_TYPE_FAILED_IMAGE_NOT_SUPPORTED=Cannot ${action} ${type}. The
image format is not supported.
Line 973: ACTION_TYPE_FAILED_IMAGE_UNRECOGNIZED=Cannot ${action} ${type}. The
image is missing or its format is corrupted or unrecognizable
Minor change: "Cannot ${action} ${type}. Either the image is missing, or its
format is corrupted or unrecognizable."
Line 974: ACTION_TYPE_FAILED_VOLUME_OPERATION_IN_PROGRESS=Cannot ${action}
${type}. A task is in progress on the volume ${volumeName} in cluster
${vdsGroup}.
Line 975: ACTION_TYPE_FAILED_GLUSTER_VOLUME_REBALANCE_NOT_STARTED=Cannot
${action} ${type}. Rebalance is not running on the volume ${volumeName} in
cluster ${vdsGroup}.
Line 976: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_VALUES=Cannot ${action}
${type}. All three values are needed in order to define QoS on each network
directions.
Line 977: ACTION_TYPE_FAILED_NETWORK_QOS_NEGATIVE_VALUES=Cannot ${action}
${type}. Negative values are not allowed.
--
To view, visit http://gerrit.ovirt.org/19370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecba90adfc2be50fb1471ac93908fde176696404
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
