Sahina Bose has posted comments on this change.
Change subject: engine: Gluster task monitoring for tasks started from CLI
......................................................................
Patch Set 1:
(3 comments)
Updated patchset to follow
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 91:
Line 92: @Override
Line 93: public Void runInTransaction() {
Line 94: createJobToMonitor(task);
Line 95: return null;
Void is the return object that TransactionMethod takes. note that this is not
the java void.
Line 96: }
Line 97: });
Line 98: }
Line 99: //update status in step table
Line 125: StepEnum step = task.getType().getStep();
Line 126: VdcActionType actionType;
Line 127: switch (step) {
Line 128: case REBALANCING_VOLUME:
Line 129: actionType = VdcActionType.StartRebalanceGlusterVolume;
Yes, thanks. Will add
Line 130: default:
Line 131: actionType = VdcActionType.Unknown;
Line 132: }
Line 133:
Line 130: default:
Line 131: actionType = VdcActionType.Unknown;
Line 132: }
Line 133:
Line 134: VdcReturnValueBase result =
Backend.getInstance().RunAction(VdcActionType.AddExternalJob,
Correcting this, will post patch
Line 135: new AddInternalJobParameters(actionType, true) );
Line 136: if (!result.getSucceeded()) {
Line 137: //log and return
Line 138: throw new VdcBLLException(result.getFault().getError());
--
To view, visit http://gerrit.ovirt.org/19183
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb6385cbcad988351f23bda2294c8e85dde54560
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
