Martin Sivák has posted comments on this change.
Change subject: vdsm: add console device to the VM
......................................................................
Patch Set 1:
(1 comment)
Just one minor comment, see inside.
....................................................
File src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
Line 153: ].split(',')
Line 154: if x
Line 155: ]
Line 156: for items in spice_values:
Line 157: key, val = items.split('=')
I am not sure if that can happen, but what if some value contains the =
character? Wouldn't it be better to use split(',', 1)?
Line 158: if key == 'CN':
Line 159: host = val
Line 160: break
Line 161:
--
To view, visit http://gerrit.ovirt.org/19369
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieabe9538571a6e4e18217a728c71677225b1fddb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnata...@gmail.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Timothy Hildred <thild...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
