Ori Liel has posted comments on this change. Change subject: restapi : Adding support for multiplre storage domains at rest part for add vm scenarious ......................................................................
Patch Set 2: (2 inline comments) only documentation issues .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java Line 113: //therefore, even if user passed storage-domain, it is ignored in this context. remove this comment - now it's possible to state the domain on which the disk will be created. .................................................... Commit Message Line 11: all logic contains at engine code Please add to commit message that after this patch, REST-API will have two options to choose the storage-domains that the disks will be created on: 1) Add all disks inline, with storage-domain ID set in each disk 2) Don't add any disks inline, and set the storage-domain id only on the VM object. In this case all disks will be added to the storage domain that was passed in the VM. 3) Don't pass disks inline, and don't set storage-domain id inside the VM. In this case the disks will be created on the storage-domain where the template disks exist. -- To view, visit http://gerrit.ovirt.org/3553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03de6426b8567f15d45eca50d2a12dd1c8ce0607 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
