Maor Lipchuk has submitted this change and it was merged. Change subject: core: Cleanup UpdateStoragePoolCommand, etc. ......................................................................
core: Cleanup UpdateStoragePoolCommand, etc. Clean up UpgradeStoragePoolCommand, its superclass and its test. 1. Replace FQCNs with imports. 2. Extract DbFacade.getXXXDAO() to helepr methods for easier testing 3. Clean up test and remove dependecy on PowerMockito 4. Spelling, comments cleanup Change-Id: I4e4763f685120ab2190c364ee74b09c01080275e --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java 3 files changed, 123 insertions(+), 101 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e4763f685120ab2190c364ee74b09c01080275e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
