Alexander Wels has posted comments on this change. Change subject: webadmin: help icon overflow ......................................................................
Patch Set 2: Code-Review-1 I talked to Tomas a little bit and this patch looks bad in oVirt. I think it basically comes down to where do we put the ? on the screen. Right now we have it floating to right of the text, and if the text covers the entire top of the window the ? overflows onto the next line. This patch fixes the ? just to the right of the div that contains the text, so it doesn't overflow, however that causes the question mark to just sort of hang in mid air in the title bar which is also not really desirable. Maybe we should get some input from an UIX expert to help determine what should happen. -- To view, visit http://gerrit.ovirt.org/19030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10abcbd977df4367584cc22529b47334c4c00d99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
