Maor Lipchuk has submitted this change and it was merged. Change subject: core: Improvements for AddEmptyStoragePoolCommand ......................................................................
core: Improvements for AddEmptyStoragePoolCommand Made some minor improvements: 1. Java cleanup 2. Extracted DAOs and helpers to getXXX() methods to facilitate testing 3. Wrote unit test to prove changes in (1) had no averse effects. Change-Id: I0691b67dbf6c823421e0a66879ab6b7bafe06bba --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommandTest.java 2 files changed, 117 insertions(+), 13 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0691b67dbf6c823421e0a66879ab6b7bafe06bba Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
