Sahina Bose has uploaded a new change for review.
Change subject: gluster: Return UNKNOWN status for GlusterTaskStatus
......................................................................
gluster: Return UNKNOWN status for GlusterTaskStatus
If the string value passed to GlusterTaskStatus is not
one of the enum options return UNKNOWN as the option
value.
Fixes 2 issues reported by coverity scan when converting
vdsm return value
GlusterAsyncTaskStatus.from((String)map.get(STATUS)).getJobExecutionStatus()
-- possible NPE
Change-Id: If8cd725af21639827ba19c5589fe2889e1c98c19
Signed-off-by: Sahina Bose <sab...@redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTaskStatus.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/19308/1
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTaskStatus.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTaskStatus.java
index 82b6533..2b80902 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTaskStatus.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTaskStatus.java
@@ -31,7 +31,7 @@
}
}
- return null;
+ return GlusterAsyncTaskStatus.UNKNOWN;
}
public JobExecutionStatus getJobExecutionStatus() {
--
To view, visit http://gerrit.ovirt.org/19308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8cd725af21639827ba19c5589fe2889e1c98c19
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
