Liran Zelkha has posted comments on this change. Change subject: engine : Change VdsUpdateRuntimeInfo to work with BatchUpdates ......................................................................
Patch Set 1: (6 comments) Done. Allon - please note that the Exception you asked for is deprecated - I used it anyway. .................................................... Commit Message Line 9: Batch Updates greatly improve performance, and this patch aims to replace multiple updates Line 10: in VdsUpdateRuntimeInfo to batch calls. Line 11: Line 12: Change-Id: I6dea40226cd1f3ec44367a27598b24b59ab49aae Line 13: Bug-Url: https://bugzilla.redhat.com/?????? Done .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java Line 162: Line 163: @Override Line 164: public MapSqlParameterMapper<GlusterBrickEntity> getBatchMapper() { Line 165: // TODO: Implement this Line 166: throw new RuntimeException("Unsupported operation"); Done Line 167: } .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java Line 302: Line 303: @Override Line 304: public MapSqlParameterMapper<GlusterHookEntity> getBatchMapper() { Line 305: // TODO: Implement this Line 306: throw new RuntimeException("Unsupported operation"); Done Line 307: } .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterOptionDaoDbFacadeImpl.java Line 96: Line 97: @Override Line 98: public MapSqlParameterMapper<GlusterVolumeOptionEntity> getBatchMapper() { Line 99: // TODO: Implement this Line 100: throw new RuntimeException("Unsupported operation"); Done Line 101: } .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoDbFacadeImpl.java Line 117: Line 118: @Override Line 119: public MapSqlParameterMapper<GlusterServerService> getBatchMapper() { Line 120: // TODO: Implement this Line 121: throw new RuntimeException("Unsupported operation"); Done Line 122: } .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java Line 438: Line 439: @Override Line 440: public MapSqlParameterMapper<GlusterVolumeEntity> getBatchMapper() { Line 441: // TODO: Implement this Line 442: throw new RuntimeException("Unsupported operation"); Done Line 443: } -- To view, visit http://gerrit.ovirt.org/19274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dea40226cd1f3ec44367a27598b24b59ab49aae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
