Alissa Bonas has uploaded a new change for review.
Change subject: core: remove not needed init in storage command
......................................................................
core: remove not needed init in storage command
Removed not needed initialization of local variable
in RemoveStorageServerConnectionCommand. (findbugs)
Change-Id: I493ebdda675ef3731e7fe72f704610b69ea8d722
Signed-off-by: Alissa Bonas <abo...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/78/19278/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java
index 986cf30..31dec16 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java
@@ -32,7 +32,7 @@
@Override
protected boolean canDoAction() {
String connectionId = getConnection().getid();
- List<StorageDomain> domains = new ArrayList<>();
+ List<StorageDomain> domains = null;
if (StringUtils.isEmpty(connectionId) ) {
return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_CONNECTION_ID_EMPTY);
}
--
To view, visit http://gerrit.ovirt.org/19278
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I493ebdda675ef3731e7fe72f704610b69ea8d722
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
