Allon Mureinik has posted comments on this change. Change subject: core: permission filtering for GetVdsCertificateSubjectByVdsId ......................................................................
Patch Set 2: (1 inline comment) basically looks OK (although I'd like to have a flow test there too), but need to consult regarding this configuration values. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsCertificateSubjectByVdsIdQuery.java Line 24: .setReturnValue( I think this is OK, but we need to check if this information should really be accessible to a user - e.g., OrganizationName does not appear in ConfigurationValues. -- To view, visit http://gerrit.ovirt.org/2965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I455e7cf746d7ec8efe1a480b5bdeeff490aa2146 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
