Hello Alon Bar-Lev, Kanagaraj M, Sahina Bose,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/19174

to review the following change.

Change subject: packaging: move package group name globally
......................................................................

packaging: move package group name globally

This patch enables seemless use of group name for downstream products.

Change-Id: I49b344a82773de57b3f8dacda12092cd3da43e30
Signed-off-by: Bala.FA <barum...@redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 12 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/74/19174/1

diff --git a/ovirt-engine.spec.in b/ovirt-engine.spec.in
index fac969c..a04fa37 100644
--- a/ovirt-engine.spec.in
+++ b/ovirt-engine.spec.in
@@ -37,6 +37,7 @@
 
 %global ovirt_product_name oVirt Engine
 %global ovirt_product_name_short oVirt Engine
+%global ovirt_product_group Virtualization/Management
 %global ovirt_user_description oVirt Manager
 
 %global engine_cache %{_localstatedir}/cache/%{engine_name}
@@ -122,7 +123,7 @@
 Version:       @RPM_VERSION@
 Release:       @RPM_RELEASE@%{?release_suffix}%{?dist}
 Summary:       Management server for Open Virtualization
-Group:         Virtualization/Management
+Group:         %{ovirt_product_group}
 License:       ASL 2.0
 URL:           http://www.ovirt.org
 Source0:       
http://ovirt.org/releases/stable/src/@PACKAGE_NAME@-@package_vers...@.tar.gz
@@ -175,7 +176,7 @@
 
 %package lib
 Summary:       %{ovirt_product_name_short} library
-Group:         Virtualization/Management
+Group:         %{ovirt_product_group}
 Requires:      python-daemon
 
 %description lib
@@ -183,7 +184,7 @@
 
 %package backend
 Summary:       Engine core of %{ovirt_product_name_short}
-Group:         Virtualization/Management
+Group:         %{ovirt_product_group}
 Requires:      %{name} = %{version}-%{release}
 Requires:      %{name}-lib
 Requires:      httpd
@@ -252,7 +253,7 @@
 
 %package restapi
 Summary:       RESTful API for %{ovirt_product_name_short}
-Group:         Virtualization/Management
+Group:         %{ovirt_product_group}
 Requires:      %{name} = %{version}-%{release}
 
 %description restapi
@@ -270,7 +271,7 @@
 
 %package setup
 Summary:       Setup and upgrade scripts for %{ovirt_product_name_short}
-Group:         Virtualization/Management
+Group:         %{ovirt_product_group}
 Requires:      %{name}
 Requires:      %{name}-lib
 Requires:      bind-utils
@@ -303,7 +304,7 @@
 
 %package dbscripts
 Summary:       Database scripts for %{ovirt_product_name_short}
-Group:         Virtualization/Management
+Group:         %{ovirt_product_group}
 Requires:      %{name} = %{version}-%{release}
 
 %description dbscripts
@@ -311,7 +312,7 @@
 
 %package userportal
 Summary:       User Portal of %{ovirt_product_name_short}
-Group:         Virtualization/Management
+Group:         %{ovirt_product_group}
 Requires:      %{name} = %{version}-%{release}
 
 %description userportal
@@ -319,7 +320,7 @@
 
 %package webadmin-portal
 Summary:       Web Admin Portal of %{ovirt_product_name_short}
-Group:         Virtualization/Management
+Group:         %{ovirt_product_group}
 Requires:      %{name} = %{version}-%{release}
 
 %description webadmin-portal
@@ -327,7 +328,7 @@
 
 %package tools
 Summary:       %{ovirt_product_name_short} Tools
-Group:         Virtualization/Management
+Group:         %{ovirt_product_group}
 Requires:      %{name} = %{version}-%{release}
 Requires:      %{name}-lib
 Requires:      java
@@ -384,7 +385,7 @@
 
 %package websocket-proxy
 Summary:       %{ovirt_product_name_short} Websocket Proxy
-Group:         Virtualization/Management
+Group:         %{ovirt_product_group}
 Requires:      %{name}-lib
 Requires:      m2crypto
 Requires:      python-websockify
@@ -424,7 +425,7 @@
 
 %package setup-plugin-allinone
 Summary:       All-in-one plugin for %{ovirt_product_name_short}'s setup
-Group:         Virtualization/Management
+Group:         %{ovirt_product_group}
 Requires:      %{name}-sdk >= 3.3.0.5
 Requires:      %{name}-setup >= %{version}-%{release}
 Requires:      openssh-server


-- 
To view, visit http://gerrit.ovirt.org/19174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49b344a82773de57b3f8dacda12092cd3da43e30
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to