Alon Bar-Lev has posted comments on this change.
Change subject: engine: application touches a file to detect un orderly shutdown
......................................................................
Patch Set 6:
(1 comment)
....................................................
File packaging/services/ovirt-engine/ovirt-engine.py
Line 469:
Line 470: except self.TerminateException:
Line 471: self.removePidFile()
Line 472:
Line 473: def removePidFile(self):
removeMarkFile?
also, I like symmetry... so if you have remove method, you should also have
create method...
Line 474: if os.path.exists(self._config.get('ENGINE_UP_MARK')):
Line 475: os.remove(self._config.get('ENGINE_UP_MARK'))
Line 476:
Line 477: def daemonCleanup(self):
--
To view, visit http://gerrit.ovirt.org/19102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8de64637299e7932a5a2761c7bb495373c418aa
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
