Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: VDS Cmd: gluster remove bricks status
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeRemoveBricksStatusVDSCommand.java
Line 27: List<GlusterBrickEntity> bricksList =
getParameters().getBricks();
Line 28: List<String> brickNames = new ArrayList<String>();
Line 29: for (GlusterBrickEntity brick : bricksList) {
Line 30: brickNames.add(brick.getQualifiedName());
Line 31: }
Will for string[] directly
Line 32:
Line 33: result =
getBroker().glusterVolumeRemoveBrickStatus(volumeName,
(String[])brickNames.toArray(), getParameters().getReplicaCount());
Line 34: proceedProxyReturnValue();
Line 35:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
Line 1257: }
Line 1258: }
Line 1259:
Line 1260: @Override
Line 1261: public GlusterVolumeTaskReturnForXmlRpc
glusterVolumeRemoveBrickStatus(String volumeName, String[] bricksList, int
replicaCount) {
replicaCount is not required for status. Will remove the same.
It was kept like this to keep in sync with VDSM verb. Buit as the field in VDSM
verb is optional argument, we can remove this.
Line 1262: try {
Line 1263: Map<String, Object> xmlRpcReturnValue =
vdsServer.glusterVolumeRemoveBrickStatus(volumeName, bricksList, replicaCount);
Line 1264: GlusterVolumeTaskReturnForXmlRpc wrapper = new
GlusterVolumeTaskReturnForXmlRpc(xmlRpcReturnValue);
Line 1265: return wrapper;
--
To view, visit http://gerrit.ovirt.org/19106
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21da52b06c6d48fa5e344909b7d78d044c902b4b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
