Allon Mureinik has posted comments on this change.
Change subject: engine: Add audit log messages to GetAlignmentScanCommand
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java
Line 132: @Override
Line 133: protected void executeCommand() {
Line 134: GetDiskAlignmentVDSCommandParameters parameters;
Line 135:
Line 136: AuditLogDirector.log(this,
AuditLogType.DISK_ALIGNMENT_SCAN_START);
This should be part of getAuditLogTypeValue() - you should also check
getActionState().
See, e.g. AddVmCommand.
Line 137:
Line 138: acquireExclusiveDiskDbLocks();
Line 139:
Line 140: // Live scan is not supported yet, this might become:
getVm().getId()
--
To view, visit http://gerrit.ovirt.org/19136
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4400aea34bd848416e67b7bb77a92b4fd581ff1e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
