Omer Frenkel has posted comments on this change.
Change subject: engine: Incorrect VM TimeZone handling
......................................................................
Patch Set 7:
(1 comment)
looks ok, need roy to look as well on validation related changes, thanks!
(minor comment inside)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
Line 61: VmTemplateHandler.UpdateDisksFromDb(mOldTemplate);
Line 62: if (mOldTemplate.getStatus() == VmTemplateStatus.Locked) {
Line 63: return
failCanDoAction(VdcBllMessages.VM_TEMPLATE_IS_LOCKED);
Line 64: }
Line 65:
this change is not needed
Line 66: if (!StringUtils.equals(mOldTemplate.getName(),
getVmTemplate().getName())
Line 67: && isVmTemlateWithSameNameExist(getVmTemplateName())) {
Line 68:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED);
Line 69: } else {
--
To view, visit http://gerrit.ovirt.org/17524
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd36656bd4f0288e86b1cbd46d702fa68051e28b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
