Tomas Jelinek has posted comments on this change.
Change subject: engine: Cache spice support for os/compatibility version
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 3083:
Line 3084: return osNames.get(osId);
Line 3085: }
Line 3086:
Line 3087: public static Boolean hasSpiceSupport(int osId, Version version)
{
Well, in this case it really can not be null as it is being read from the
VmBase. If it was read from EntityModel it would be pretty vulnerable (as
setting the EntityModel's value to null and than to the real value is pretty
normal there).
I can accept it to be "int" in this case as it is more clean. But we will need
to be careful if someone will use it somewhere else in the future.
Line 3088: return spiceSupportMatrix.get(osId).get(version);
Line 3089: }
Line 3090:
Line 3091: private static void initHasSpiceSupport() {
--
To view, visit http://gerrit.ovirt.org/19137
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib97d68ccd0d30fd07e8d1a7d1322f731aef220f7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
