Shubhendu Tripathi has posted comments on this change.
Change subject: engine:VDS Command for Start Gluster volume remove brick
......................................................................
Patch Set 4:
(7 comments)
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
Line 340: GlusterVolumeResetOptionsFailed=Gluster Volume Options Reset Failed
Line 341: GlusterVolumeRemoveBricksFailed=Gluster Volume Remove Bricks Failed
Line 342: GlusterVolumeRemoveBricksStartFailed=Failed to start remove Gluster
Volume Bricks
Line 343: GlusterVolumeRemoveBricksStopFailed=Failed to stop remove Gluster
Volume Bricks
Line 344: GlusterVolumeRemoveBricksCommitFailed=Failed to commit remove Gluster
Volume Bricks operation
Why the word "operation" is not present in other entries?
May be you can remove in all the places.
Line 345: GlusterVolumeProfileStartFailed=Gluster Volume Profile Start Failed
Line 346: GlusterVolumeProfileStopFailed=Gluster Volume Profile Stop Failed
Line 347: GlusterAddHostFailed=Gluster Server Add Failed
Line 348: GlusterHostRemoveFailed=Gluster Server Remove Failed
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StartRemoveGlusterVolumeBricksVDSCommand.java
Line 26: getParameters().getReplicaCount(),
Line 27: getParameters().isForceRemove());
Line 28: task = glusterTaskReturn.getGlusterTask();
Line 29: setReturnValue(task);
Line 30: proceedProxyReturnValue();
Mostly we call processProxyReturnValue() before setting the return value.
The setting of the retunr value should be the last statement.
Line 31: }
Line 32:
Line 33: @Override
Line 34: public Object getReturnValue() {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
Line 205: GlusterVolumeOptionsInfoReturnForXmlRpc
glusterVolumeSetOptionsList();
Line 206:
Line 207: GlusterTaskInfoReturnForXmlRpc
glusterVolumeRemoveBricksStart(String volumeName,
Line 208: String[] brickList,
Line 209: int replicCount,
Mis-spelt. SHould be "replicaCount"
Line 210: Boolean forceRemove);
Line 211:
Line 212: StatusOnlyReturnForXmlRpc glusterVolumeRemoveBricksStop(String
volumeName,
Line 213: String[] brickList,
Line 210: Boolean forceRemove);
Line 211:
Line 212: StatusOnlyReturnForXmlRpc glusterVolumeRemoveBricksStop(String
volumeName,
Line 213: String[] brickList,
Line 214: int replicCount);
Mis-spelt. SHould be "replicaCount"
Line 215:
Line 216: StatusOnlyReturnForXmlRpc glusterVolumeRemoveBricksCommit(String
volumeName,
Line 217: String[] brickList,
Line 218: int replicCount);
Line 214: int replicCount);
Line 215:
Line 216: StatusOnlyReturnForXmlRpc glusterVolumeRemoveBricksCommit(String
volumeName,
Line 217: String[] brickList,
Line 218: int replicCount);
Mis-spelt. SHould be "replicaCount"
Line 219:
Line 220: StatusOnlyReturnForXmlRpc glusterVolumeBrickAdd(String volumeName,
Line 221: String[] bricks,
Line 222: int replicaCount,
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
Line 705:
Line 706: @DefaultStringValue("Failed to stop remove Gluster Volume
Bricks.")
Line 707: String GlusterVolumeRemoveBricksStopFailed();
Line 708:
Line 709: @DefaultStringValue("Failed to commit remove Gluster Volume
Bricks operation.")
The word "operation" is looking different here as its not there for other
entries.
Line 710: String GlusterVolumeRemoveBricksCommitFailed();
Line 711:
Line 712: @DefaultStringValue("Gluster Volume Add Brick Failed.")
Line 713: String AddBricksToGlusterVolumeFailed();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
Line 347: GlusterVolumeDeleteFailed=Gluster Volume Delete Failed.
Line 348: GlusterVolumeRemoveBricksFailed=Gluster Volume Remove Bricks Failed.
Line 349: GlusterVolumeRemoveBricksStartFailed= Failed to start remove Gluster
Volume Bricks.
Line 350: GlusterVolumeRemoveBricksStopFailed=Failed to stop remove Gluster
Volume Bricks.
Line 351: GlusterVolumeRemoveBricksCommitFailed=Failed to commit remove Gluster
Volume Bricks operation.
Same as earlier
Line 352: AddBricksToGlusterVolumeFailed=Gluster Volume Add Brick Failed.
Line 353: GlusterVolumeRebalanceStartFailed=Gluster Volume Rebalance Start
Failed.
Line 354: GlusterVolumeRebalanceStopFailed=Gluster Volume Rebalance Stop Failed
Line 355: GlusterVolumeReplaceBrickStartFailed=Gluster Volume Replace Brick
Start Failed.
--
To view, visit http://gerrit.ovirt.org/18881
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a4d829c43a209b51d14c952bac1ada77e40083b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
