Moti Asayag has posted comments on this change. Change subject: core: Add queries for fetching Permitted Storage Domains ......................................................................
Patch Set 2: (9 inline comments) .................................................... File backend/manager/dbscripts/storages_sp.sql Line 384: I'll rename it to Getstorage_domains_by_storage_pool_id_with_permitted_action for consistency with the bottom part of this file :-) Line 391: WHERE storage_pool_id = v_storage_pool_id it will fail due to the way get_entity_permissions is implemented. Line 396: the potential return value will be a single entity. Using plural might mislead the reader. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByVmTemplateIdQuery.java Line 38: agreed, however there is no method at the moment of passing an array as argument to the STP. This approach exists in other queries as well, we should address it differently if it raises a DB issues. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java Line 224: GetLunsByVgId, Done .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java Line 150: */ I kept the same convention as laid by StorageDao.getDataCentersWithPermittedActionOnClusters (userId, ActionGroupId) .................................................... File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java Line 320: @Test That's the use of the annotation - to annotate this is a test function :-) I assume that moving from Junit3 to 4 left the "test" prefix on those methods. I'll change it for the sake of consistency with this class only. Line 331: @Test Done Line 341: @Test Done -- To view, visit http://gerrit.ovirt.org/3436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I155cb9f187b951b399e99b54007cf24e3163251a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
