Daniel Erez has posted comments on this change.
Change subject: webadmin: Only add VNIC if profiles available
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 1039: behavior.initProfiles(hotUpdateSupported,
getModel().getSelectedCluster().getId(),
getModel().getSelectedDataCenter().getId(), query);
Line 1040: }
Line 1041:
Line 1042: private boolean profilesExist(List<VnicProfileView> profiles) {
Line 1043: return !(profiles.isEmpty() || (profiles.size() == 1 &&
profiles.get(0) == null));
can we consider an even simpler approach? :)
[or, is there a case when only the first item is null?]
* E.g. return profiles.size() > 0 && profiles.get(0) != null;
Line 1044: }
Line 1045:
Line 1046: public void updateSingleQxl(boolean visible) {
Line 1047: getModel().getIsSingleQxlEnabled().setIsAvailable(visible);
--
To view, visit http://gerrit.ovirt.org/18818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b582711252be833300a8819c86159dd9058c1e9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
