Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: i18n remove user role dialog ......................................................................
Patch Set 1: Code-Review+1 (2 comments) Patch looks good, just some minor comments regarding gwt-common's PresenterWidget binding. .................................................... File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java Line 252: Line 253: // Main section: popups Line 254: Line 255: // Permissions removal Line 256: bindPresenterWidget(RolePermissionsRemoveConfirmationPopupPresenterWidget.class, This PresenterWidget is in gwt-common so its binding should rather be in gwt-common's BasePresenterModule. Line 257: RolePermissionsRemoveConfirmationPopupPresenterWidget.ViewDef.class, Line 258: RolePermissionsRemoveConfirmationPopupView.class); Line 259: Line 260: // Permissions .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java Line 953: PermissionsPopupPresenterWidget.ViewDef.class, Line 954: PermissionsPopupView.class); Line 955: Line 956: // Permissions removal Line 957: bindPresenterWidget(RolePermissionsRemoveConfirmationPopupPresenterWidget.class, This PresenterWidget is in gwt-common so its binding should rather be in gwt-common's BasePresenterModule. Line 958: RolePermissionsRemoveConfirmationPopupPresenterWidget.ViewDef.class, Line 959: RolePermissionsRemoveConfirmationPopupView.class); Line 960: Line 961: bindPresenterWidget(SystemPermissionsRemoveConfirmationPopupPresenterWidget.class, -- To view, visit http://gerrit.ovirt.org/18936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida914d031978326ce6743dd8e83bfa6276a9a964 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
