Daniel Erez has uploaded a new change for review. Change subject: core: prevent SyncLunsInfo for DirectLUN ......................................................................
core: prevent SyncLunsInfo for DirectLUN 'ISCSIStorageHelper -> runConnectionStorageToDomain()' is used also for connecting DirectLUN disks (RunVmCommandBase -> connectLunDisks), hence storgaeDomain can be null. Change-Id: Ifd76bb5ecaac2c71f0daefd5ddbefa2e3536599d Bug-Url: https://bugzilla.redhat.com/1005572 Signed-off-by: Daniel Erez <de...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/18988/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java index 1194471..b799dc6 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java @@ -63,7 +63,7 @@ if (isSuccess && VDSCommandType.forValue(type) == VDSCommandType.ConnectStorageServer) { isSuccess = isConnectSucceeded((Map<String, String>) returnValue.getReturnValue(), list); - if (isSuccess) { + if (isSuccess && storageDomain != null) { // Synchronize LUN details comprising the storage domain with the DB StorageDomainParametersBase parameters = new StorageDomainParametersBase(storageDomain.getId()); parameters.setVdsId(vdsId); -- To view, visit http://gerrit.ovirt.org/18988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd76bb5ecaac2c71f0daefd5ddbefa2e3536599d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
