Martin Peřina has posted comments on this change. Change subject: core: Delays JNDI binding in Injector until needed ......................................................................
Patch Set 3: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java Line 127: * This method is called upon the bean creation as part of the management Service bean lifecycle. Line 128: */ Line 129: @PostConstruct Line 130: public void create() { Line 131: CommandsFactory.initCdi(); Well, since Backend is marked as @Singleton and @Startup, its @PostConstruct method is the first place, that an exception can be thrown (AFAIK exceptions thrown in EJBs constructor are not allowed in EJB > 3.x). And about injection, it means that during execution of PostConstruct method all injected instances for this particular are already available, but it has no connection with injections to other beans. Line 132: checkDBConnectivity(); Line 133: Initialize(); Line 134: } Line 135: -- To view, visit http://gerrit.ovirt.org/18904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I776169e8f1b906395ef9290093c18aeaebf489db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches