Tal Nisan has posted comments on this change. Change subject: core: simpler syntax for snapshotEntityStatus ......................................................................
Patch Set 3: Code-Review+2 (1 comment) .................................................... Commit Message Line 13: Rationale and benefits: Line 14: 1. Most of the time (i.e., all the calls except one), when taking a Line 15: snapshot of an entity's status, you use the status property of the Line 16: entity, which makes for an annoying call: Line 17: getCompensationContext().snapshotEntutyStatus(e, e.getStatus()); s/snapshotEntutyStatus/snapshotEntityStatus Line 18: The proposed syntax is more straight-forward and simpler to Line 19: understand: Line 20: getCompensationContext().snapshotEntutyStatus(e); Line 21: -- To view, visit http://gerrit.ovirt.org/18859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib074a96e93f1c68637306b670b70983f26042514 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
