Yaniv Bronhaim has posted comments on this change.

Change subject: API: editing host update and add fields
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 2210:           host.power_management.pm_proxy--COLLECTION: {propietary : 
'xs:string'}, host.power_management.agents.agent--COLLECTION:{type: 'xs:string',
Line 2211:           address: 'xs:string', user_name: 'xs:string', password: 
'xs:string', options.option--COLLECTION: {option.name: 'xs:string', 
option.value: 'xs:string'}}}
Line 2212:         description: update the specified host in the system. This 
is deprecated and is provided only for backwards compatibility
Line 2213:       - mandatoryArguments: {}
Line 2214:         optionalArguments: {host.name: 'xs:string', host.comment: 
'xs:string', host.address: 'xs:string', host.ssh.fingerprint: 'xs:string', 
host.display.address: 'xs:string',
Yes, 1003281 and 999640 are the bugs that complain about the ovirt shell 
parameters. because all added to the code wrongly (as i was not familiar yet 
with this code and its meaning and its output - now I know and it won't happen 
again) , by mistake we have this code in as it was first implemented. 

This is how it should be, I don't think we require specific bug on it, we could 
just refer this change to the RFE bz also if you prefer, but both  1003281 and 
999640 are fixed in this patch scope, and there is no need to split it (it 
won't mean anything)
Line 2215:           host.cluster.id|name: 'xs:string', host.port: 'xs:int', 
host.storage_manager.priority: 'xs:int', host.power_management.type: 
'xs:string',
Line 2216:           host.power_management.enabled: 'xs:boolean', 
host.power_management.address: 'xs:string', host.power_management.username: 
'xs:string',
Line 2217:           host.power_management.password: 'xs:string', 
host.power_management.options.option--COLLECTION: {option.name: 'xs:string',
Line 2218:           option.value: 'xs:string'},  
host.power_management.pm_proxy--COLLECTION: {propietary : 'xs:string'},


-- 
To view, visit http://gerrit.ovirt.org/18754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640cfca4057ffd65d37afc10bc5ac2e12f1aafd5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to