Tal Nisan has posted comments on this change. Change subject: core: VdcActionUtils: Unwrap else blocks ......................................................................
Patch Set 2: Code-Review+2 Looks ok basically but I'd rewrite this method totally, I don't understand why there is a check on the class name string if an instanceof check is performed and even if there is some hidden logic behind checking the class name, why use endsWith and not equals? -- To view, visit http://gerrit.ovirt.org/18852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I475e1c4a99ba004bc3ebe2182a7351a0d28dcbda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
