Vojtech Szocs has uploaded a new change for review. Change subject: engine: Add no-arg constructor to Parameters classes ......................................................................
engine: Add no-arg constructor to Parameters classes This is required in order to avoid potential serialization issues with GWT RPC. Change-Id: I54a256a7a9c36485630740d82bc0393561f9516a Signed-off-by: Vojtech Szocs <vsz...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActivateDeactivateVmNicParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalEventParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalJobParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalStepParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDettachVmDiskParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeQuotaParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalJobParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalStepParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/GetDiskAlignmentParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostStoragePoolParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RegisterDiskParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveExternalEventParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVdsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdUsersSearchParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAuditLogByIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostsForStorageOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImageByIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStepsByJobIdQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDiskQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDisksQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmByVmNameForDataCenterParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmFromConfigurationQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasAdElementReconnectPermissionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SignStringParameters.java 25 files changed, 76 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/18908/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActivateDeactivateVmNicParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActivateDeactivateVmNicParameters.java index 807eb3d..82fdcaa 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActivateDeactivateVmNicParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActivateDeactivateVmNicParameters.java @@ -8,6 +8,9 @@ private VmNic nic; private PlugAction action; + public ActivateDeactivateVmNicParameters() { + } + public ActivateDeactivateVmNicParameters(VmNic nic, PlugAction action) { super(); this.nic = nic; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalEventParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalEventParameters.java index f1cc184..176dd77 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalEventParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalEventParameters.java @@ -4,12 +4,16 @@ public class AddExternalEventParameters extends VdcActionParametersBase { private static final long serialVersionUID = 7023971593753015624L; + private AuditLog event; public AuditLog getEvent() { return event; } + public AddExternalEventParameters() { + } + public AddExternalEventParameters(AuditLog event) { super(); this.event = event; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalJobParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalJobParameters.java index 80ace4e..b63690e 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalJobParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalJobParameters.java @@ -10,6 +10,9 @@ private String description; private boolean isAutoCleared; + public AddExternalJobParameters() { + } + public AddExternalJobParameters(String description, boolean isAutoCleared) { super(); this.description = description; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalStepParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalStepParameters.java index dd1a60e..82ef9a3 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalStepParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalStepParameters.java @@ -38,6 +38,9 @@ this.description = description; } + public AddExternalStepParameters() { + } + public AddExternalStepParameters(Guid id, String description, StepEnum stepType) { super(); this.parentId = id; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDettachVmDiskParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDettachVmDiskParameters.java index abdc2eb..fffb775 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDettachVmDiskParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDettachVmDiskParameters.java @@ -9,6 +9,9 @@ private static final long serialVersionUID = 5640716432695539552L; private boolean isPlugUnPlug; + public AttachDettachVmDiskParameters() { + } + public AttachDettachVmDiskParameters(Guid vmId, Guid diskId, boolean isPlugUnPlug) { super(vmId, null); setEntityInfo(new EntityInfo(VdcObjectType.Disk, diskId)); diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeQuotaParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeQuotaParameters.java index b9b25bb..4519d7f 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeQuotaParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeQuotaParameters.java @@ -11,6 +11,9 @@ private Guid quotaId; private Guid objectId; + public ChangeQuotaParameters() { + } + /** * @param quotaId the new quota id * @param entityId vm or disk diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalJobParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalJobParameters.java index bbb316e..e05fba4 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalJobParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalJobParameters.java @@ -38,6 +38,9 @@ this.force = force; } + public EndExternalJobParameters() { + } + public EndExternalJobParameters(Guid jobId, JobExecutionStatus status, boolean force) { super(); this.jobId = jobId; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalStepParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalStepParameters.java index a5863c5..db15351 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalStepParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalStepParameters.java @@ -28,6 +28,9 @@ this.exitStatus = status; } + public EndExternalStepParameters() { + } + public EndExternalStepParameters(Guid id, boolean status) { super(); this.id = id; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/GetDiskAlignmentParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/GetDiskAlignmentParameters.java index 9fe53b9..ade2582 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/GetDiskAlignmentParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/GetDiskAlignmentParameters.java @@ -7,6 +7,9 @@ private Guid diskId; + public GetDiskAlignmentParameters() { + } + public GetDiskAlignmentParameters(Guid diskId) { setDiskId(diskId); } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostStoragePoolParametersBase.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostStoragePoolParametersBase.java index a6510db..6773b80 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostStoragePoolParametersBase.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostStoragePoolParametersBase.java @@ -9,6 +9,9 @@ private VDS vds; private StoragePool storagePool; + public HostStoragePoolParametersBase() { + } + public HostStoragePoolParametersBase(VDS vds) { super(vds.getStoragePoolId(), vds.getId()); this.vds = vds; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RegisterDiskParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RegisterDiskParameters.java index ce952a3..ea930be 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RegisterDiskParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RegisterDiskParameters.java @@ -9,6 +9,9 @@ private DiskImage diskImage; + public RegisterDiskParameters() { + } + public RegisterDiskParameters(DiskImage diskImage, Guid storageDomainId) { super(diskImage.getId()); this.diskImage = diskImage; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveExternalEventParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveExternalEventParameters.java index 8c7c718..a0fc1eb 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveExternalEventParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveExternalEventParameters.java @@ -5,6 +5,9 @@ private static final long serialVersionUID = 1L; private long id; + public RemoveExternalEventParameters() { + } + public RemoveExternalEventParameters(Long id) { this.id = id; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVdsParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVdsParameters.java index 834280a..8ef52b3 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVdsParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVdsParameters.java @@ -7,6 +7,9 @@ private boolean forceAction; + public RemoveVdsParameters() { + } + public RemoveVdsParameters(Guid vdsId) { super(vdsId); } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParameters.java index 6a8910c..f7464be 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParameters.java @@ -10,6 +10,9 @@ public class AdGroupsSearchParameters extends SearchParameters { private static final long serialVersionUID = -4695945267348177923L; + public AdGroupsSearchParameters() { + } + public AdGroupsSearchParameters(String searchPattern) { super(searchPattern, SearchType.AdGroup); } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdUsersSearchParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdUsersSearchParameters.java index c397de1..c994ae2 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdUsersSearchParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdUsersSearchParameters.java @@ -10,6 +10,9 @@ public class AdUsersSearchParameters extends SearchParameters { private static final long serialVersionUID = -2788510087018816667L; + public AdUsersSearchParameters() { + } + public AdUsersSearchParameters(String searchPattern) { super(searchPattern, SearchType.AdUser); } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAuditLogByIdParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAuditLogByIdParameters.java index 4fbabba..49c723b 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAuditLogByIdParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAuditLogByIdParameters.java @@ -2,6 +2,9 @@ public class GetAuditLogByIdParameters extends VdcQueryParametersBase { + public GetAuditLogByIdParameters() { + } + public GetAuditLogByIdParameters(Long id) { super(); this.id = id; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostsForStorageOperationParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostsForStorageOperationParameters.java index 9af5bca..d24a7ee 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostsForStorageOperationParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostsForStorageOperationParameters.java @@ -6,6 +6,9 @@ private boolean localFsOnly; + public GetHostsForStorageOperationParameters() { + } + public GetHostsForStorageOperationParameters(Guid storagePoolId, boolean localFsOnly) { super(storagePoolId); this.localFsOnly = localFsOnly; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImageByIdParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImageByIdParameters.java index 5222a80..b1db470 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImageByIdParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImageByIdParameters.java @@ -11,6 +11,9 @@ private Guid storageDomainId; + public GetImageByIdParameters() { + } + public GetImageByIdParameters(Guid storageDomainId, String repoImageId) { setStorageDomainId(storageDomainId); setRepoImageId(repoImageId); diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStepsByJobIdQueryParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStepsByJobIdQueryParameters.java index 65a44d5..122f7d1 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStepsByJobIdQueryParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStepsByJobIdQueryParameters.java @@ -6,6 +6,9 @@ private static final long serialVersionUID = 758029173419093849L; + public GetStepsByJobIdQueryParameters() { + } + public GetStepsByJobIdQueryParameters(Guid jobId) { super(); this.jobId = jobId; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDiskQueryParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDiskQueryParameters.java index 8a6dd6c..20a353b 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDiskQueryParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDiskQueryParameters.java @@ -8,6 +8,9 @@ private Guid diskId; + public GetUnregisteredDiskQueryParameters() { + } + public GetUnregisteredDiskQueryParameters(Guid diskId, Guid storageDomainId, Guid storagePoolId) { super(storageDomainId, storagePoolId); this.diskId = diskId; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDisksQueryParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDisksQueryParameters.java index eff06b3..98b2a47 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDisksQueryParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDisksQueryParameters.java @@ -7,6 +7,9 @@ private Guid storagePoolId; + public GetUnregisteredDisksQueryParameters() { + } + public GetUnregisteredDisksQueryParameters(Guid storageDomainId, Guid storagePoolId) { super(storageDomainId); this.storagePoolId = storagePoolId; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmByVmNameForDataCenterParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmByVmNameForDataCenterParameters.java index 79bc3a1..5895505 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmByVmNameForDataCenterParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmByVmNameForDataCenterParameters.java @@ -4,9 +4,13 @@ public class GetVmByVmNameForDataCenterParameters extends VdcQueryParametersBase { private static final long serialVersionUID = -3232978226860645746L; + private Guid dataCenterId; private String name; + public GetVmByVmNameForDataCenterParameters() { + } + public GetVmByVmNameForDataCenterParameters(Guid dataCenterId, String name) { this.dataCenterId = dataCenterId; this.name = name; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmFromConfigurationQueryParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmFromConfigurationQueryParameters.java index 2aa57da..dc0afbe 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmFromConfigurationQueryParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmFromConfigurationQueryParameters.java @@ -7,6 +7,9 @@ private String vmConfiguration; private ConfigurationType configurationType; + public GetVmFromConfigurationQueryParameters() { + } + public GetVmFromConfigurationQueryParameters(ConfigurationType configurationType, String vmConfiguration) { super(); this.configurationType = configurationType; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasAdElementReconnectPermissionParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasAdElementReconnectPermissionParameters.java index d0f4744..8b882d7 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasAdElementReconnectPermissionParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasAdElementReconnectPermissionParameters.java @@ -9,6 +9,9 @@ private Guid adElementId; private Guid objectId; + public HasAdElementReconnectPermissionParameters() { + } + public HasAdElementReconnectPermissionParameters(Guid adElementId, Guid objectId) { this.adElementId = adElementId; this.objectId = objectId; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SignStringParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SignStringParameters.java index 5f14359..208486b 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SignStringParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SignStringParameters.java @@ -6,6 +6,8 @@ private String string; + public SignStringParameters() { + } public SignStringParameters(String string) { super(); -- To view, visit http://gerrit.ovirt.org/18908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I54a256a7a9c36485630740d82bc0393561f9516a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches