Maor Lipchuk has posted comments on this change. Change subject: core: Fix DAO use with templates multiple storages ......................................................................
Patch Set 1: (4 inline comments) Hi Michael, thanks for the comments The problem is that the test of the DAO will fail, if I will return empty list, since we count on empty Guid (because that is what Guid.createGuidFromString returned before when we got null values) I agree with you it is a wrong behaviour but it should be dealt in another patch. I will send it seperated patch of this fix .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/StringUtils.java Line 161: */ Agreed. Line 177: */ Kublin, I am simply following the behaviour which was before. In the DiskImageDaoTest we explicitly compare new empty Guid for storage id with what we get from the DB. I don't want to change this behaviour now in this patch. I totally agree with you it is wrong, but it should be fixed in another patch. Line 180: ArrayList<Guid> storageGuidsList = new ArrayList<Guid>(); Agreed will remove Line 187: // If list is empty return empty guid. See my comment above. This is a change in the behaviour, it should be in another patch, and well tested. -- To view, visit http://gerrit.ovirt.org/3477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96b3bbe4a20cd34252f7f0df48464f571e41c1c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
