Omer Frenkel has posted comments on this change.
Change subject: core : Renaming of AddiskToVmCommand to AddDiskCommand
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 114: true,
the isValid check that is done inside ImagesHandler.PerformImagesChecks is
relevant also if there is no vm, also i dont understand why we dont check the
storage domain status as well
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 126: if (StringUtils.isEmpty(diskAlias)) {
maybe should be null or empty
--
To view, visit http://gerrit.ovirt.org/3390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ceedd24a49f33e79d6dadab3a64c237bad512ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
