Livnat Peer has posted comments on this change.
Change subject: core: Reuse default quota on DC update
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
I wrote an optional comment, other than that looks good to me.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
Line 65: private void updateDefaultQuota() {
It is a matter of personal preference so take it or leave it :)
I would use a method isQuotaStausChangedToDisable() and write the if condition
inside
just makes the code easier to read.
--
To view, visit http://gerrit.ovirt.org/3426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62ef006c8f572210abba97393cc2e601235e40
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
