Maor Lipchuk has posted comments on this change. Change subject: core: Remove PowerMockito from QuotaHelperTest ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java Line 127: quota.setGraceStoragePercentage(getIntegerConfig(ConfigValues.QuotaGraceStorage)); If already decided to refactor it,it would be great if it can be refactor to four different methods. It might be useful later on. BTW Consider adding the getIntegerConfig and other method types to the Config class maybe, its much more cleaner then Config.<Integer> GetValue, and could clean our code in many places -- To view, visit http://gerrit.ovirt.org/3422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccc1c8a2fe77f4303d5e7f06b5dfa1d628faed89 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
