Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup UpdateStoragePoolCommand, etc.
......................................................................
Patch Set 3: (5 inline comments)
Looks good, only minor cosmetic comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
Line 103: }
Maybe simply add a new parameter at the beginning of the method, and return it
at the end of it.
Line 115:
Please remove empty line
Line 257:
Consider add an alternative comment, since LinqUtils is not quite clear
Line 371: /* Config methods - for easier testing */
I think better to have a a java doc comment here, since it is already in the
class perspective.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
Line 138: protected boolean isVersionSupported() {
Since the storage pool is referenced in the parameters, maybe change the method
name to something like isStoragePoolVersionSupported.
or add the etStoragePool().getcompatibility_version() as a parameter in the
method signature.
--
To view, visit http://gerrit.ovirt.org/3425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e4763f685120ab2190c364ee74b09c01080275e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
