Moti Asayag has posted comments on this change. Change subject: core: Add disk actions and predefined roles ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/03_01_0780_add_disks_roles.sql Line 1: Create or replace FUNCTION insert_predefined_roles() It will not be supported: create_db.sh invokes the insert_initial_data which adds the predefined roles. Upgrade.sh doesn't call that method - therefore roles are being reloaded. same reason for having 03_00_0150_update_roles.sql which updates the existing. However, i think it would be better giving a unique name for this function. -- To view, visit http://gerrit.ovirt.org/3396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idafea6a0c42baceba1b5a4a312a9531e90da433f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
