Maor Lipchuk has submitted this change and it was merged. Change subject: core: No empty quotas in storage global default ......................................................................
core: No empty quotas in storage global default This patch is intended to stop retuning empty quotas in getQuotaStorageByQuotaGuidWithGeneralDefault. A boolean parameter was added to getQuotaStorageByStorageGuid to determine whether empty quotas should or should not be returned, and getQuotaStorageByQuotaGuidWithGeneralDefault was changed to call it with false. In order to test this behaviour, an additional empty quota was added to fixtures.xml, and the test on the total number of quotas were fixed accordingly. Change-Id: Ib2d3d992115b8ba88072fff6e14a54fbc43bcb9e --- M backend/manager/dbscripts/quota_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 6 files changed, 91 insertions(+), 17 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2d3d992115b8ba88072fff6e14a54fbc43bcb9e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
