Omer Frenkel has posted comments on this change. Change subject: engine: Stop Gluster Volume ......................................................................
Patch Set 1: (1 inline comment) i would recommend writing unit tests for new command, currently tests to verify canDoAction logic, that could be expended later on. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java Line 20: setGlusterVolumeId(getParameters().getVolumeId()); i think that the gluster volume id is already set in the super constructor. -- To view, visit http://gerrit.ovirt.org/3348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c9a58e3b3bab27fa6a2ed78e3864acb4b94b590 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
